ef46f0cbf4 ci: fix action that comments on Release PRs (#6663) Fixes issues with the action that comments updates on merged release PRs: 1. Multi-line LINKS_VALUE: Use '%s\n%s' command substitution instead of literal newline 2. Heredoc delimiter: Changed to COMMENT_BODY_END_MARKER without quotes 3. Variable bug: Fixed incorrect variable (`$URL` not `$URL_TEMPLATE`) 4. Change from `printf` to `echo` (avoid weird printf gymnastics) ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-6663-ci-fix-action-that-comments-on-Release-PRs-2a96d73d365081b1b0c5c8e66f0e317f) by [Unito](https://www.unito.io)
02d303c039 [chore] Add Oxc linter to project (#6197) ## Summary - Adds [Oxc linter](https://oxc.rs/docs/guide/usage/linter) as a dev dependency - Creates minimal `.oxlintrc.json` configuration file - Integrates oxlint into the lint workflow (runs before ESLint) - Adds `pnpm oxlint` script for standalone usage - **NEW**: Adds [eslint-plugin-oxlint](https://github.com/oxc-project/eslint-plugin-oxlint) to disable redundant ESLint rules - Updates `CLAUDE.md` documentation with oxlint command ## Motivation Oxc is a high-performance Rust-based linter that is 50-100x faster than ESLint. By integrating it into our lint workflow, we get: - **Faster CI/CD pipelines** (5% improvement in this codebase) - **Quicker local development feedback** - **Additional code quality checks** that complement ESLint - **Reduced duplicate work** by disabling ESLint rules that oxlint already checks ## Changes - **package.json**: Added `oxlint` and `eslint-plugin-oxlint` to devDependencies, integrated into `lint`, `lint:fix`, and `lint:no-cache` scripts - **pnpm-workspace.yaml**: Added `eslint-plugin-oxlint` and `mixpanel-browser` to catalog - **eslint.config.ts**: Integrated `eslint-plugin-oxlint` to automatically disable redundant ESLint rules - **.oxlintrc.json**: Created minimal configuration file with schema reference - **CLAUDE.md**: Added `pnpm oxlint` to Quick Commands section - **.gitignore**: Added `core` dump files ## CI/CD Performance Benchmark Real-world CI/CD timing from GitHub Actions workflow runs: ### Baseline (ESLint only) - [Run #18718911051](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/18718911051) - Run ESLint with auto-fix: **125s** - Final validation (lint + format + knip): **16s** - **Total: 141s** ### With Oxlint (oxlint + ESLint) - [Run #18719037963](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/18719037963) - Run ESLint with auto-fix (includes oxlint): **118s** - Final validation (includes oxlint + lint + format + knip): **16s** - **Total: 134s** ### Results ✅ **7 seconds faster (5.0% improvement)** despite running an additional linting pass ### Analysis The oxlint integration actually **improves** CI/CD performance by ~5%. This unexpected improvement is likely because: 1. **Oxlint catches issues early**: Some code that would have slowed down ESLint's parsing/analysis is caught by oxlint first 2. **ESLint cache benefits**: The workflow uses `--cache`, and oxlint's fast execution helps populate/validate the cache more efficiently 3. **Parallel processing**: Modern CI runners can overlap some of the I/O operations between oxlint and ESLint Even if oxlint added overhead, the value proposition would still be strong given its additional code quality checks and local development speed benefits. The fact that it actually speeds up the pipeline is a bonus. ## eslint-plugin-oxlint Performance Impact Benchmark comparing ESLint performance with and without eslint-plugin-oxlint: ### Baseline (ESLint without plugin) - [Run #18723242157](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/18723242157) - Run ESLint with auto-fix: **122s** (2m 2s) - Final validation: **17s** ### With eslint-plugin-oxlint - [Run #18723675903](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/18723675903) - Run ESLint with auto-fix: **129s** (2m 9s) - Final validation: **12s** ### Results **Performance: +7 seconds ESLint, -5 seconds validation (net +2 seconds)** The eslint-plugin-oxlint integration has a **minimal performance impact** (+2 seconds total). The slight increase in ESLint time is likely due to the additional plugin configuration overhead, while the validation step is faster because fewer redundant lint warnings need to be processed. ### Benefits The small performance cost is outweighed by important benefits: 1. **Prevents duplicate work**: Disables ~50 ESLint rules that oxlint already checks (e.g., `no-constant-condition`, `no-debugger`, `no-empty`, etc.) 2. **Reduces noise**: Eliminates redundant lint warnings from two tools checking the same thing 3. **Cleaner workflow**: One authoritative source for each type of lint check 4. **Best practice**: Recommended by the Oxc project for ESLint + oxlint integration 5. **Consistent results**: Ensures both tools don't conflict or give contradictory advice ## Usage ```bash # Run oxlint standalone pnpm oxlint # Run full lint workflow (oxlint + ESLint) pnpm lint pnpm lint:fix ``` ## Notes - Oxlint now runs as part of the standard `pnpm lint` workflow - The configuration uses minimal rules by default (Oxc's philosophy is "catch erroneous or useless code without requiring any configurations by default") - Oxlint provides fast feedback while ESLint provides comprehensive checks - eslint-plugin-oxlint automatically manages rule conflicts between the two tools - Both tools complement each other in the linting pipeline 🤖 Generated with [Claude Code](https://claude.com/claude-code) ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-6197-chore-Add-Oxc-linter-to-project-2946d73d3650818cbb55ef9c0abdb9b9) by [Unito](https://www.unito.io) --------- Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: GitHub Action <action@github.com> Co-authored-by: DrJKL <DrJKL0424@gmail.com>
23b0d2eb7f Add front end support for type matching (#6582) This PR implements front end logic to handle MatchType inputs and outputs. See comfyanonymous/ComfyUI#10644 This allows for the implementation of nodes such as a "switch node" where input types change based on the connections made.  As part of this implementation, significant cleanup is being performed in the reroute code. Extra testing will be required to make sure these changes don't introduce regressions. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-6582-Add-front-end-support-for-type-matching-2a16d73d36508189b042cd23f82a332e) by [Unito](https://www.unito.io)
1e71eae177 Persist template filters (#6657) This pull request adds persistent filter and sort settings to the template library, allowing users' filter choices and sort preferences to be saved and restored across sessions. The main changes include integrating the settings store with the template filtering composable, updating the schema and core settings, and ensuring filter changes are saved efficiently. **Template Library Filter Persistence:** * [`src/composables/useTemplateFiltering.ts`](diffhunk://#diff-a1ec9d65962033526942cbcabeac8538ef3cd723e2e9e889cf668ccf6270d167L1-R32): The filter state (`selectedModels`, `selectedUseCases`, `selectedRunsOn`, and `sortBy`) is now initialized from the settings store and changes are persisted back using debounced watchers. This ensures user preferences are saved and restored. [[1]](diffhunk://#diff-a1ec9d65962033526942cbcabeac8538ef3cd723e2e9e889cf668ccf6270d167L1-R32) [[2]](diffhunk://#diff-a1ec9d65962033526942cbcabeac8538ef3cd723e2e9e889cf668ccf6270d167R259-R291) * [`src/platform/settings/constants/coreSettings.ts`](diffhunk://#diff-9fb7e2cdcdc60a92bdb54698fb49909bd2a84a50ffb69e2b60529a948eeb9756R1056-R1083): Added new hidden settings for template filter selections and sort preference, with sensible defaults. * [`src/schemas/apiSchema.ts`](diffhunk://#diff-b769532e74f826ca909951c0c34331b9246efb3f6901ff95a856ecf01ad826beR504-R514): Updated the settings schema to include the new template filter and sort settings, ensuring type safety and validation. **Default Behavior Adjustment:** * [`src/composables/useTemplateFiltering.ts`](diffhunk://#diff-a1ec9d65962033526942cbcabeac8538ef3cd723e2e9e889cf668ccf6270d167L200-R209): Changed the default sort order when clearing filters to `'newest'` to match the new default in settings. https://github.com/user-attachments/assets/259e87e6-20b3-4c91-b1bf-4b7d70649878 ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-6657-Persist-template-filters-2a86d73d3650818ca46fda23a6528391) by [Unito](https://www.unito.io)
- Compare 8 commits »
liuzx
- Joined on Oct 20, 2020
- Organization
-
-
-
20
-
2
-
-
86
-
0
-
-
73
-
0
-
-
33
-
0
-
-
97
-
0
-
-
35
-
41
-
-
7
-
0
-
-
9
-
1
-
-
7
-
0
-
-
108
-
1
-
-
16
-
0
-
-
32
-
2
-
-
103
-
5
-
-
1
-
1
-
Loading Heatmap…
liuzx synced commits to main at liuzx/ComfyUI_frontend from mirror
5 hours ago
liuzx synced commits to main at liuzx/ComfyUI-Manager from mirror
70decc740f update DB
773c06f40d Add ComfyUI Fast Mosaic Detector node (#2274) Added a new custom node for ComfyUI that provides high-speed mosaic detection with multiple modes.
81bca9c94e Update custom-node-list.json (#2273) * Update custom-node-list.json * Modify 'world weaver' node details in JSON Updated the 'id' and 'install_type' fields for the 'world weaver' node. --------- Co-authored-by: Dr.Lt.Data <128333288+ltdrdata@users.noreply.github.com>
- Compare 12 commits »
10 hours ago
liuzx synced commits to master at liuzx/ComfyUI from mirror
1199411747 Don't pin tensor if not a torch.nn.parameter.Parameter (#10718)
15 hours ago
liuzx synced commits to rizumu/refactor/use-defineAsyncComponent-for-widget-components at liuzx/ComfyUI_frontend from mirror
7454a38dfe test: Check identity on the async component. Doing a check of the resolved value using a Suspense would be much more complex
18 hours ago
liuzx synced commits to right-click-vue-node-contextmenu at liuzx/ComfyUI_frontend from mirror
8b95385ca7 refactor: remove unused menuOptionExists function
- Compare 31 commits »
18 hours ago
liuzx synced commits to rh-test at liuzx/ComfyUI_frontend from mirror
5bd2a098e2 [backport rh-test] cloud: fix credits tooltips (#6658) Backport of #6655 to `rh-test` Automatically created by backport workflow. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-6658-backport-rh-test-cloud-fix-credits-tooltips-2a96d73d365081f6aa28ef959cada111) by [Unito](https://www.unito.io) Co-authored-by: Christian Byrne <cbyrne@comfy.org>
- Compare 2 commits »
18 hours ago
liuzx synced commits to main at liuzx/ComfyUI_frontend from mirror
30fc784ae4 Complete locale translations (#6637) ### Summary - filled missing keys across `src/locales/*/{main,nodeDefs,settings,commands}.json` so every locale now matches the English source set - normalized pluralization templates and preserved placeholders during the refresh - synced newly translated strings for Arabic, Spanish, French, Japanese, Korean, Russian, Turkish, and Traditional Chinese ### Chinese <img width="3456" height="1994" alt="image" src="https://github.com/user-attachments/assets/c7c1ab0d-638c-4570-96ed-a96abc0cacb5" /> ### Japanese <img width="3456" height="1986" alt="image" src="https://github.com/user-attachments/assets/d34d557e-0725-4d1a-abde-195f8d78f4f2" /> ### Korean <img width="3456" height="1984" alt="image" src="https://github.com/user-attachments/assets/c5ce31d9-1237-42e0-aa63-d7baaa1f9916" /> ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-6637-Complete-locale-translations-2a56d73d365081c68178dd180b8c6777) by [Unito](https://www.unito.io)
- Compare 9 commits »
18 hours ago
liuzx synced commits to feat/cloud-e2e-tests at liuzx/ComfyUI_frontend from mirror
- Compare 2 commits »
18 hours ago
liuzx synced commits to main at liuzx/ComfyUI_frontend from mirror
879cb8f1a8 support panoramic image in 3d node (#6638) ## Summary Adds panoramic image support to the 3D node viewer, allowing users to display equirectangular panoramic images as immersive backgrounds alongside the existing tiled image mode. ## Changes - Toggle between tiled and panorama rendering modes for background images - Field of view (FOV) control for panorama mode - Refactored FOV slider into reusable PopupSlider component ## Screenshots https://github.com/user-attachments/assets/8955d74b-b0e6-4b26-83ca-ccf902b43aa6 ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-6638-support-panoramic-image-in-3d-node-2a56d73d365081b98647f988130e312e) by [Unito](https://www.unito.io)
c94cedf8ee add 'SaveVideo' into saveNodeTypes (#6647) ## Summary add 'SaveVideo' into saveNodeTypes to fix [ComfyUI 10285](https://github.com/comfyanonymous/ComfyUI/issues/10285) and [ComfyUI 10479](https://github.com/comfyanonymous/ComfyUI/issues/10479) ## Changes add 'SaveVideo' into saveNodeTypes values ## Review Focus is this enough? ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-6647-add-SaveVideo-into-saveNodeTypes-2a76d73d365081d9bb7eccc358c9836d) by [Unito](https://www.unito.io)
- Compare 2 commits »
1 day ago
liuzx synced commits to main at liuzx/ComfyUI-Manager from mirror
b32cab6e9a Fix: Gracefully handle errors during pip package enumeration (#2266)
7067de1bb2 request to add the node comfyui fmj llm in the manager. (#2265) * Add FMJ-LLM node for Olama interaction Added a new node for FMJ-LLM with details about its functionality and installation. * Add FMJ-LLM node for Olama interaction Added new node for FMJ-LLM with details for installation and usage. * Update custom-node-list.json --------- Co-authored-by: Dr.Lt.Data <128333288+ltdrdata@users.noreply.github.com>
- Compare 14 commits »
1 day ago
liuzx pushed to fix-doc-703 at OpenI/aiforge
4a547f16aa Merge pull request 'modify image' (#7059) from V20251016.patch into V20251030 Reviewed-on: https://openi.pcl.ac.cn/OpenI/aiforge/pulls/7059
b483abff09 Merge pull request 'fix bug' (#7053) from fix-bug-1106 into V20251030 Reviewed-on: https://openi.pcl.ac.cn/OpenI/aiforge/pulls/7053
- Compare 16 commits »
1 day ago
liuzx synced commits to master at liuzx/ComfyUI from mirror
2 days ago
liuzx created CPU/GPU type Comfy UI task liuzx202511110925971
2 days ago
liuzx created CPU/GPU type Comfy UI task liuzx202511110925881
2 days ago
liuzx created CPU/GPU type Comfy UI task liuzx202511110925836
2 days ago
liuzx commented on issue zeizei/OpenI_Learning#1492
可以提供关于华为NPU更新的镜像吗？比如基于CANN8.2或者8.3的mindspore套件？社区上有一个910b资源的新版镜像，是cann8.3.rc1，名称为：cann8_3_rc1 注意需要选择D910B资源
2 days ago
liuzx created CPU/GPU type Comfy UI task liuzx202511110923886
2 days ago
liuzx synced commits to sno-api-changelog at liuzx/ComfyUI_frontend from mirror
e9b641cfb7 [bugfix] Fix Storybook _sfc_main undefined error after v1.29.3 (#6635) ## Summary Fixes Storybook rendering issue where all components fail to load with `_sfc_main is not defined` error in **local development** since v1.29.3. ## Problem After upgrading to v1.29.3, all Storybook components fail to render **in local development** (`pnpm storybook`) with the following error: ``` ReferenceError: _sfc_main is not defined The component failed to render properly, likely due to a configuration issue in Storybook. ``` **Important**: This issue only affects **local development** environments. The deployed/built Storybook works correctly. This affects both: - Main Storybook (`pnpm storybook`) - Desktop-ui Storybook instances ## Root Cause In v1.29.3, commit `64430708e` ("perf: tree shaking and minify #6068") enabled build optimizations in `vite.config.mts`: ```typescript // Before (v1.29.2) rollupOptions: { treeshake: false } esbuild: { minifyIdentifiers: false } // After (v1.29.3) rollupOptions: { treeshake: true // ⚠️ Enabled } esbuild: { minifyIdentifiers: SHOULD_MINIFY // ⚠️ Conditionally enabled } ``` While these optimizations are beneficial for production builds, they cause issues in **Storybook's local dev server**: 1. **Tree-shaking in dev mode**: Rollup incorrectly identifies Vue SFC's `_sfc_main` exports as unused code during the dev server's module transformation 2. **Identifier minification**: esbuild minifies `_sfc_main` to shorter names in development, breaking Storybook's HMR (Hot Module Replacement) and dynamic module loading Since Storybook's `main.ts` inherits settings from `vite.config.mts` via `mergeConfig`, these optimizations were applied to Storybook's dev server configuration, causing Vue components to fail rendering in local development. **Why deployed Storybook works**: Production builds have different optimization pipelines that handle Vue SFCs correctly, but the dev server's real-time transformation breaks with these settings. ## Solution Added explicit build configuration overrides in both Storybook configurations to ensure the **dev server** doesn't inherit problematic optimizations: **Files changed:** - `.storybook/main.ts` - `apps/desktop-ui/.storybook/main.ts` **Changes:** ```typescript esbuild: { // Prevent minification of identifiers to preserve _sfc_main in dev mode minifyIdentifiers: false, keepNames: true }, build: { rollupOptions: { // Disable tree-shaking for Storybook dev server to prevent Vue SFC exports from being removed treeshake: false, // ... existing onwarn config } } ``` This ensures Storybook's **local development server** prioritizes stability and debuggability over bundle size optimization, while production builds continue to benefit from tree-shaking and minification. ## Testing 1. Cleared Storybook and Vite caches: `rm -rf .storybook/.cache node_modules/.vite` 2. Started local Storybook dev server with `pnpm storybook` 3. Verified all component stories render correctly without `_sfc_main` errors 4. Ran `pnpm typecheck` to ensure TypeScript compilation succeeds 5. Tested HMR (Hot Module Replacement) works correctly with component changes ## Context - This is a **local development-only** issue; deployed Storybook builds work fine - Storybook dev server requires special handling because it dynamically imports and hot-reloads all stories at runtime - Vue SFC compilation generates `_sfc_main` as an internal identifier that must be preserved during dev transformations - Development tools like Storybook benefit from unoptimized builds for better debugging, HMR, and stability - Production builds remain optimized with tree-shaking and minification enabled ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-6635-bugfix-Fix-Storybook-_sfc_main-undefined-error-after-v1-29-3-2a56d73d36508194a25eef56789e5e2b) by [Unito](https://www.unito.io)
- Compare 26 commits »
2 days ago
liuzx synced commits to drjkl/node-height at liuzx/ComfyUI_frontend from mirror
ef07a77795 [automated] Update test expectations
- Compare 3 commits »
2 days ago