#873 [WIP]add embedding_bag api

Open

zoulq wants to merge 1 commits from zlq2 into master

mindspore目前未提供对应接口，暂时拼接实现部分功能, 图模式语法限制功能不支持，性能差距大。待MindSpore框架支持对应算子功能。

zoulq changed title from ~~[WIP] add embedding_bag api~~ to add embedding_bag api 2 months ago

Erpim reviewed 2 months ago

mindtorch/torch/nn/functional.py

												
			@@ -2770,0 +2777,4 @@
		
			        raise RuntimeError("`embedding_bag` unsupported on GRAPH_MODE Now.")
		
			    if scale_grad_by_freq is not False or per_sample_weights is not None or include_last_offset is not False:
		
			        raise NotImplementedError("Currently, values other than the default are not supported.")

Erpim commented 2 months ago

报错信息是否再准确一些? 除这三个外其他带有默认值的入参也只支持默认值吗?

zoulq commented 2 months ago

其他参数取值没有约束

zoulq changed title from ~~add embedding_bag api~~ to [WIP]add embedding_bag api 2 months ago

continuous-integration/drone/pr Build is passing

Details

continuous-integration/drone/push Build is passing

Details

This pull request has changes conflicting with the target branch.

mindtorch/torch/nn/functional.py

testing/ut/pytorch/nn/test_sparse.py

No reviewers

No Label

No Milestone

No Assignees

2 Participants

Notifications

Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.